Skip to content

fix: lint error in device notifications (v0.14.1) #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yakari007 merged 1 commit into from
Oct 12, 2026
Merged

fix: lint error in device notifications (v0.14.1) #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/progress.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ Suppression: a pool host that goes down suppresses its VMs' incidents and the ch

Verified by `TestPool`, `TestPoolFollowsMaster`, `TestPoolFailures` (fake pool), `TestDiscoveredDevices` (engine, devices, incidents, metrics, limits, retention) and `TestDiscoveredHostSuppression`.

### v0.14.0 — notification catalog and device notifications
### v0.14.1 — notification catalog and device notifications (v0.14.0 failed lint)

`GET /v1/notification-catalog` and `GET /v1/devices/{device_id}/notifications` ([F06](features/F06-notifications.md#notification-catalog-and-device-view)): a customer sees which routes take a device's incidents, whether their webhooks work, whether the next incident would fire (`would_fire` with a `reason`), and the deliveries about the device with their payloads. Migration `00025` links deliveries to devices. Verified by `TestDeviceNotifications`.

Expand Down
3 changes: 1 addition & 2 deletions internal/api/handlers_notifications.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package api

import (
"context"
"encoding/json"

"github.com/jackc/pgx/v5"

Expand Down Expand Up @@ -88,7 +87,7 @@ func (s *Server) ListDeviceNotifications(ctx context.Context, req gen.ListDevice
"route_id": d.RouteID, "route_name": d.RouteName, "route_external": d.RouteExternal,
"endpoint_id": d.EndpointID, "endpoint_name": d.EndpointName, "endpoint_external": d.EndpointExt, "status": d.Status, "attempts": d.Attempts,
"last_status_code": d.LastStatusCode, "last_error": d.LastError, "last_attempt_at": d.LastAttemptAt,
"delivered_at": d.DeliveredAt, "created_at": d.CreatedAt, "payload": json.RawMessage(d.Payload),
"delivered_at": d.DeliveredAt, "created_at": d.CreatedAt, "payload": d.Payload,
}
}
res, err := via[gen.DeviceNotifications](out)
Expand Down