Repository navigation
docs: link repo files with absolute URLs instead of page-relative paths - #721
Open
SoulmatelynchVFX wants to merge 1 commit into
Open
SoulmatelynchVFX wants to merge 1 commit into
SoulmatelynchVFX wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two links in the introduction pages point at repo files with page-relative paths, so they resolve against the docs route instead of the repository root and end up 404 on the built site:
docs/getting-started/introduction.mdx→components/mdx/index.tsxdocs/authoring/introduction.mdx→.github/workflows/build.ymlChange
Point both at the file on GitHub with absolute URLs:
https://github.com/pmndrs/docs/blob/main/src/components/mdx/index.tsxhttps://github.com/pmndrs/docs/blob/main/.github/workflows/build.ymlOnly the link targets change, no wording edits.
Verification
Both targets return 200:
git diff --stat: 2 files changed, 2 insertions(+), 2 deletions(-).