Skip to content

fix(STLLoader): guard isBinary against buffers shorter than 84 bytes #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fursund wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(STLLoader): guard isBinary against buffers shorter than 84 bytes #431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/loaders/STLLoader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,13 @@ class STLLoader extends Loader {
parse(data) {
function isBinary(data) {
const reader = new DataView(data)

// A binary STL is at minimum an 80-byte header followed by a 4-byte
// uint32 face count (84 bytes total). Anything shorter cannot be
// binary; treat it as ASCII to avoid an out-of-bounds DataView read
// on short but legal ASCII solids (e.g. "solid s\nendsolid s\n").
if (reader.byteLength < 84) return false

const face_size = (32 / 8) * 3 + (32 / 8) * 3 * 3 + 16 / 8
const n_faces = reader.getUint32(80, true)
const expect = 80 + 32 / 8 + n_faces * face_size
Expand Down
Loading