Skip to content

fix(OrbitControls): guard against undefined second pointer position #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adamistheanswer wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(OrbitControls): guard against undefined second pointer position #432

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/controls/OrbitControls.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,6 +777,7 @@ class OrbitControls extends EventDispatcher<StandardControlsEventMap> {
rotateEnd.set(event.pageX, event.pageY)
} else {
const position = getSecondPointerPosition(event)
if (!position) return
const x = 0.5 * (event.pageX + position.x)
const y = 0.5 * (event.pageY + position.y)
rotateEnd.set(x, y)
Expand All @@ -798,6 +799,7 @@ class OrbitControls extends EventDispatcher<StandardControlsEventMap> {
panEnd.set(event.pageX, event.pageY)
} else {
const position = getSecondPointerPosition(event)
if (!position) return
const x = 0.5 * (event.pageX + position.x)
const y = 0.5 * (event.pageY + position.y)
panEnd.set(x, y)
Expand All @@ -810,6 +812,7 @@ class OrbitControls extends EventDispatcher<StandardControlsEventMap> {

function handleTouchMoveDolly(event: PointerEvent) {
const position = getSecondPointerPosition(event)
if (!position) return
const dx = event.pageX - position.x
const dy = event.pageY - position.y
const distance = Math.sqrt(dx * dx + dy * dy)
Expand Down