docs: replace unsafe IdP request params example#2312
Closed
desimone wants to merge 1 commit into
Closed
Conversation
ENG-4222 Replace the unsafe placeholder values with a valid custom parameter and clarify that generated OAuth parameters cannot be overridden.
✅ Deploy Preview for pomerium-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This was referenced Jul 14, 2026
Greptile SummaryThis PR corrects the Identity Provider Request Params reference. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "docs: fix IdP request params example" | Re-trigger Greptile |
kenjenkins
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Identity Provider Request Params reference demonstrates
client_id,response_type, andredirect_uriwith literal placeholder values and repeats them in a Console screenshot. Those values are not inert examples: request params are appended to the authorization request, so savingclient_id=client_idcan replace the configured OAuth client and lock administrators out of the Console login flow.Replace the example with the valid custom parameter
prompt: loginand state that Pomerium-generated OAuth parameters cannot be overridden. Remove the screenshot because it only duplicates the field layout while presenting unsafe values as valid configuration.This documents the runtime protection in pomerium/pomerium#6522. The identical release-branch patch was validated in pomerium/pomerium#6523, which was closed so the normal post-merge backport automation can preserve merge order. This change does not attempt to catalog provider-specific optional parameters.
Related
Testing
yarn run checkyarn buildAI disclosure
GPT-5 Codex drafted the documentation correction from the maintainer-supplied reproduction and implementation scope; the maintainer required removal of the misleading example across the Core and 0.33 release work.
Checklist