Fix command injection in entrypoint argument handling#6
Open
charlievieth wants to merge 1 commit into
Open
Conversation
Replace `sh -c "porter $INPUT_COMMAND"` with `exec porter $INPUT_COMMAND`. The old form re-parsed the input as a shell script, so metacharacters (; | && $() backticks) in INPUT_COMMAND were executed. Direct unquoted expansion still word-splits into multiple args/flags but passes them to porter as literal argument text, closing the injection hole. Using exec also avoids the extra subshell so signals and exit codes propagate cleanly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XJ6dDbHQymBQw7zpXY64LS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
sh -c "porter $INPUT_COMMAND"withexec porter $INPUT_COMMAND. The old form re-parsed the input as a shell script, so metacharacters (; | && $() backticks) in INPUT_COMMAND were executed. Direct unquoted expansion still word-splits into multiple args/flags but passes them to porter as literal argument text, closing the injection hole. Using exec also avoids the extra subshell so signals and exit codes propagate cleanly.