feat: resolve the sandbox API base URL automatically#2
Closed
jackowfish wants to merge 1 commit into
Closed
Conversation
This was referenced Jul 7, 2026
Contributor
Author
|
Closing - re-doing this so the SDK resolves project + cluster server-side from the API key instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Porter()previously always defaulted to the in-cluster sandbox API URL, so calling from outside the cluster meant hand-assembling the Porter API proxy URL and settingPORTER_SANDBOX_BASE_URL. Now the SDK resolves it: an explicitbase_urlorPORTER_SANDBOX_BASE_URLstill wins, thenPORTER_PROJECT_ID+PORTER_CLUSTER_IDbuild the external Porter API URL, and finally in-cluster detection (KUBERNETES_SERVICE_HOST) falls back to the in-cluster service.If none of those resolve,
Config.resolveraises an error listing the options instead of timing out against acluster.localaddress. Going external without an API token, or with only one of the two IDs set, also errors up front with exactly what to set.