fix: exec runs unbounded by default and is never retried#5
Merged
Conversation
sophiajwitt
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
All requests are capped by the client-wide timeout (30s by default currently), which bounds how long
sandbox.exec()can run. The retry loop also treatedhttpx.TimeoutExceptionlike any network error, so a command that outlived that could get re-executed server-side up to three more times.Exec is long-running by nature (the API responds only once the command exits), so the generated exec method now disables the client-side timeout and is never retried: a failed attempt may have executed server-side, and re-sending it could run the command again. A per-call bound is still available through the raw resource (
porter.sandboxes.raw.exec_sandbox(id=..., body=..., timeout=120)), and timeouts elsewhere now raiseSandboxTimeoutErrorinstead of being retried.Other endpoints keep the 30s default; the server caps those anyway. The resource files are generated, so the emitter produces the new exec signature and this PR carries the matching output alongside the transport change.