ci(downstream): flip merged downstreams back to main#122
Merged
Conversation
schloerke
force-pushed
the
schloerke/gha-downstream-deps-main
branch
from
8179659 to
724a5ff
Compare
schloerke
force-pushed
the
schloerke/gha-downstream-deps-main
branch
from
2b8ad31 to
fefdf73
Compare
Entries without a `ref:` line now fall through to `main` via
`${{ matrix.ref || 'main' }}` in the step. Lets us drop the
boilerplate `ref: main` from every merged downstream and only carry
a `ref:` line when an entry actually pins to a non-main branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Flips the
ref:for each entry in.github/workflows/downstream.yamlback tomain(or removes it) as the corresponding downstream PR merges. The original workflow comment already documents this pattern.posit-dev/brand-yml#115merged (5b911ac)posit-dev/py-shiny#2244openposit-dev/shinychat#226openposit-dev/chatlas#311openI'll push follow-up commits to this branch as each remaining downstream PR merges, then merge this once they're all back on
main.Test plan
Downstreamworkflow on this PR showsposit-dev/brand-yml@mainpassing pyright against this branch's htmltools.