add write-manifest pyproject command#782
Open
amol- wants to merge 3 commits into
Open
Conversation
|
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
For connect git based deployment a
manifest.jsonis required.Manually maintaining a manifest.json is not very convenient and it's also fairly verbose,
the support for
pyproject.tomlmetadata makes much easier to maintain the important metadata values which thenrsconnect deploy pyprojectreads.This is meant to implement support for
pyproject.tomlin thewrite-manifestcommand:rsconnect write-manifest pyproject, thus allowing users to keeppyproject.tomlas their only source of truth and generate the manifest on demand from it (it is not required for normal deploys asrsconnect deploy pyprojectcan be used for those)Type of Change
Approach
pyproject.tomlmetadata parsing fromdeploy pyprojectso that it can be shared between deploy and write-manifestwrite-manifestcommand that reads the pyproject and creates the corresponding manifest for that app type reusing the already existing write manifest logic.Automated Tests
Directions for Reviewers
Checklist
rsconnect-python-tests-at-nightworkflow in Connect against this feature branch.