Skip to content

feat: track unmatched LEFT tuples for FULL JOIN Phase 3-5 collection#39

Merged
poyrazK merged 1 commit intomainfrom
feature/full-join-option-c-left-tracking
Apr 15, 2026
Merged

feat: track unmatched LEFT tuples for FULL JOIN Phase 3-5 collection#39
poyrazK merged 1 commit intomainfrom
feature/full-join-option-c-left-tracking

Conversation

@poyrazK
Copy link
Copy Markdown
Owner

@poyrazK poyrazK commented Apr 15, 2026

Summary

  • Add unmatched_left_rows_ and unmatched_left_keys_ storage to HashJoinOperator
  • Add get_unmatched_left_rows() and get_unmatched_left_keys() methods
  • During probe, store unmatched LEFT tuples instead of just emitting
  • Add unit tests for LEFT and FULL join unmatched tracking

Test plan

  • All 28 tests pass locally
  • operator_tests specifically validates LEFT tracking
  • CI passes

Related

Part of Option C implementation for FULL JOIN support.

- Add unmatched_left_rows_ and unmatched_left_keys_ storage to HashJoinOperator
- Add get_unmatched_left_rows() and get_unmatched_left_keys() methods
- During probe, store unmatched LEFT tuples instead of just emitting
- Add unit tests for LEFT and FULL join unmatched tracking
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 15, 2026

Warning

Rate limit exceeded

@poyrazK has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 35 minutes and 25 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 35 minutes and 25 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 645ca891-816a-4caf-8d58-d1a7e5faa671

📥 Commits

Reviewing files that changed from the base of the PR and between 57fc3f8 and 2b0bf75.

📒 Files selected for processing (3)
  • include/executor/operator.hpp
  • src/executor/operator.cpp
  • tests/operator_tests.cpp
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/full-join-option-c-left-tracking

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Owner Author

@poyrazK poyrazK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay to merge

@poyrazK poyrazK merged commit 62cd75e into main Apr 15, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant