Skip to content

feat: add LEFT-side infrastructure for Phase 3-5 FULL join support#41

Merged
poyrazK merged 2 commits intomainfrom
feature/full-join-option-c-infrastructure
Apr 16, 2026
Merged

feat: add LEFT-side infrastructure for Phase 3-5 FULL join support#41
poyrazK merged 2 commits intomainfrom
feature/full-join-option-c-infrastructure

Conversation

@poyrazK
Copy link
Copy Markdown
Owner

@poyrazK poyrazK commented Apr 16, 2026

Summary

  • Add ClusterManager storage methods for LEFT side (mirror of RIGHT side methods)
  • Add new RPC types: UnmatchedLeftRowsReport, FetchUnmatchedLeftRows
  • Add new RPC structs: UnmatchedLeftRowsReportArgs, FetchUnmatchedLeftRowsArgs
  • Add handlers in main.cpp for the new RPC types

Test plan

  • All relevant tests pass locally (operator_tests, distributed_tests)
  • CI passes

Notes

This is purely infrastructure - Phase 3-5 remains disabled. No functionality change.

Part of Option C implementation for FULL JOIN support.

poyrazK and others added 2 commits April 16, 2026 14:26
- Add ClusterManager storage methods for LEFT side:
  - set_local_left_rows / get_local_left_rows / clear_local_left_rows
  - set_unmatched_left_rows / get_unmatched_left_rows / clear_unmatched_left_rows
- Add new RPC types for LEFT side:
  - UnmatchedLeftRowsReport (data node reports unmatched LEFT rows)
  - FetchUnmatchedLeftRows (coordinator fetches stored unmatched LEFT rows)
- Add new RPC structs:
  - UnmatchedLeftRowsReportArgs
  - FetchUnmatchedLeftRowsArgs
- Add handlers in main.cpp for the new RPC types

This is infrastructure only - Phase 3-5 remains disabled.
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 16, 2026

Warning

Rate limit exceeded

@poyrazK has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 47 minutes and 32 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 47 minutes and 32 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 63b47c6a-1545-4069-80a8-89c3c021ce50

📥 Commits

Reviewing files that changed from the base of the PR and between 62cd75e and 6018443.

📒 Files selected for processing (3)
  • include/common/cluster_manager.hpp
  • include/network/rpc_message.hpp
  • src/main.cpp
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/full-join-option-c-infrastructure

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Owner Author

@poyrazK poyrazK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add those connections our core engine

@poyrazK poyrazK merged commit b3e07d1 into main Apr 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant