feat: add LEFT-side infrastructure for Phase 3-5 FULL join support#41
feat: add LEFT-side infrastructure for Phase 3-5 FULL join support#41
Conversation
- Add ClusterManager storage methods for LEFT side: - set_local_left_rows / get_local_left_rows / clear_local_left_rows - set_unmatched_left_rows / get_unmatched_left_rows / clear_unmatched_left_rows - Add new RPC types for LEFT side: - UnmatchedLeftRowsReport (data node reports unmatched LEFT rows) - FetchUnmatchedLeftRows (coordinator fetches stored unmatched LEFT rows) - Add new RPC structs: - UnmatchedLeftRowsReportArgs - FetchUnmatchedLeftRowsArgs - Add handlers in main.cpp for the new RPC types This is infrastructure only - Phase 3-5 remains disabled.
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 47 minutes and 32 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
poyrazK
left a comment
There was a problem hiding this comment.
Lets add those connections our core engine
Summary
UnmatchedLeftRowsReport,FetchUnmatchedLeftRowsUnmatchedLeftRowsReportArgs,FetchUnmatchedLeftRowsArgsTest plan
Notes
This is purely infrastructure - Phase 3-5 remains disabled. No functionality change.
Part of Option C implementation for FULL JOIN support.