Skip to content

feat: enable Phase 3-5 for FULL JOIN to collect unmatched LEFT rows#42

Merged
poyrazK merged 2 commits intomainfrom
feature/full-join-option-c-orchestration
Apr 16, 2026
Merged

feat: enable Phase 3-5 for FULL JOIN to collect unmatched LEFT rows#42
poyrazK merged 2 commits intomainfrom
feature/full-join-option-c-orchestration

Conversation

@poyrazK
Copy link
Copy Markdown
Owner

@poyrazK poyrazK commented Apr 16, 2026

Summary

  • Track outer_join_left_key in addition to outer_join_right_key
  • Enable Phase 3-5 for FULL JOIN (not RIGHT JOIN - RIGHT works via local executor)
  • Add LEFT-side Phase 3: UnmatchedLeftRowsReport RPC to each data node
  • Add LEFT-side Phase 4: FetchUnmatchedLeftRows RPC to collect unmatched rows
  • Aggregate unmatched LEFT rows into final results

Test plan

  • All relevant tests pass locally
  • CI passes

Implementation Notes

This implements Option C symmetric handling for FULL JOIN:

  • Unmatched RIGHT rows: collected via existing Phase 3-4
  • Unmatched LEFT rows: collected via new LEFT-side Phase 3-4

Part of Option C implementation for FULL JOIN support.

- Track outer_join_left_key in addition to outer_join_right_key
- Enable Phase 3-5 for FULL JOIN (not RIGHT JOIN - RIGHT works via local executor)
- Add LEFT-side Phase 3: UnmatchedLeftRowsReport RPC to each data node
- Add LEFT-side Phase 4: FetchUnmatchedLeftRows RPC to collect unmatched rows
- Aggregate unmatched LEFT rows into final results

This implements Option C symmetric handling for FULL JOIN:
- Unmatched RIGHT rows collected via Phase 3-4 (existing)
- Unmatched LEFT rows collected via LEFT-side Phase 3-4 (new)
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 16, 2026

Warning

Rate limit exceeded

@github-actions[bot] has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 37 minutes and 1 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 37 minutes and 1 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 26e81439-0fac-4150-8d36-60fded731965

📥 Commits

Reviewing files that changed from the base of the PR and between b3e07d1 and 52740b0.

📒 Files selected for processing (2)
  • include/network/rpc_message.hpp
  • src/distributed/distributed_executor.cpp
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/full-join-option-c-orchestration

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Owner Author

@poyrazK poyrazK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay to merge

@poyrazK poyrazK merged commit 548632b into main Apr 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant