Dont skip elements due to reordering when delete items from rate limiter

Author: rstefan1

pkg/rate-limiter/rate_limiter.go

@@ -64,14 +64,16 @@ func (r *RateLimiter) checkAndUpdateItems(ctx context.Context) {
 
 	r.notReadyItems = 0
 
+	itemsToDelete := []types.NamespacedName{}
+
 	for nsName, inTime := range r.items {
 		// give the operators/controllers 10 seconds to update item status
 		if time.Since(inTime) < r.durationToBecomeReady {
 			continue
 		}
 
 		if time.Since(inTime) > r.itemTimeout {
-			delete(r.items, nsName)
+			itemsToDelete = append(itemsToDelete, nsName)
 
 			r.log.V(0).Info("timeout exceeded", "item", nsName)
 
@@ -80,13 +82,17 @@ func (r *RateLimiter) checkAndUpdateItems(ctx context.Context) {
 
 		// check item. If it is ready, remove it from buffer
 		if r.itemIsReady(ctx, r.c, nsName, r.log) {
-			delete(r.items, nsName)
+			itemsToDelete = append(itemsToDelete, nsName)
 
 			continue
 		}
 
 		r.notReadyItems++
 	}
+
+	for _, nsName := range itemsToDelete {
+		delete(r.items, nsName)
+	}
 }
 
 func (r *RateLimiter) writeLog() {