Update dependencies, upgrade preferences and goodbye to anko#55
Merged
Conversation
robbi5
changed the title
Replace anko prefs
… and MaterialAlertDialogBuilder
robbi5
force-pushed
the
upgrade-bye-anko
branch
from
7eecca8 to
627763c
Compare
raphaelm
reviewed
Mar 16, 2023
| <?xml version="1.0" encoding="utf-8"?> | ||
| <manifest xmlns:android="http://schemas.android.com/apk/res/android" | ||
| xmlns:tools="http://schemas.android.com/tools" | ||
| package="eu.pretix.pretixprint"> |
Contributor
Author
There was a problem hiding this comment.
yep, Android Studio removed that automatically, it is now replaced by the applicationId in build.gradle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Currently based on the pin-dialog #54 branch, will be rebased when that got merged)
This PR updates gradle, kotlin and some dependencies, introduces flipper in pretixPRINT too, migrates our settings/preferences to androidx, the styling to Material3 and finally completely removes anko \o/
I've tried to split the parts into single commits for easier review.
TODO: