Add exchanging tickets to reusable media#177
Open
robbi5 wants to merge 15 commits into
Open
Conversation
…roduces a small time window where none of our code handles the tag and the system opens its own ui
Rename ExchangeScanExistingNfcDialog to ExchangeScanNfcDialog, it is generic enough
…icking down while the dialog is open
…ssible on this device or if its only deactivated, which can be fixed by the user
raphaelm
reviewed
Jun 8, 2026
| <string name="reusable_media_exchange_unknown_type">This reusable medium type is not supported</string> | ||
| <string name="reusable_media_exchange_loading_failed">Couldn\'t load information about the medium from the server</string> | ||
| <string name="reusable_media_exchange_medium_unknown">This medium is not yet known to the system</string> | ||
| <string name="reusable_media_exchange_position_unknown">Ticket details are missing, linking the medium is currently not possible</string> |
Member
There was a problem hiding this comment.
was wondering what this is but seems unused?
raphaelm
reviewed
Jun 8, 2026
| <string name="reusable_media_exchange_linking_failed">Linking the ticket to the medium failed</string> | ||
| <string name="reusable_media_exchange_no_nfc_support">This ticket requires to be exchanged to a NFC-based reusable medium. This device doesn\'t support NFC, so the exchange is not possible.</string> | ||
| <string name="reusable_media_exchange_nfc_scan">Please scan a NFC chip</string> | ||
| <string name="reusable_media_exchange_nfc_needs_nfc_unknown">A NFC chip on an unknown basis is needed - this is currently not supported</string> |
Member
There was a problem hiding this comment.
I think "an unknown basis" is hard to understand, is basis a bad German-ism here? Maybe technology?
raphaelm
reviewed
Jun 8, 2026
| else -> false | ||
| } | ||
|
|
||
| // FIXME: implement support for MediaPolicy.NEW and MediaPolicy.REUSE_OR_NEW |
Member
There was a problem hiding this comment.
Are these more complex than REUSE, now that server can auto-create media?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires pretix/libpretixsync#78 and pretix/pretix#6115