Skip to content

feat: add CSS Layer support to navigation composites#7962

Draft
joshblack wants to merge 2 commits into
css-layers/11-filtered-form-select-panelfrom
css-layers/12-navigation-composites
Draft

feat: add CSS Layer support to navigation composites#7962
joshblack wants to merge 2 commits into
css-layers/11-filtered-form-select-panelfrom
css-layers/12-navigation-composites

Conversation

@joshblack

@joshblack joshblack commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Part of https://github.com/github/primer/issues/6275

Migrates LabelGroup, NavList, SegmentedControl, TreeView, and UnderlineNav styles into named Primer component CSS layers.

Changelog

New

  • Adds CSS layer coverage for LabelGroup, NavList, SegmentedControl, TreeView, and UnderlineNav.

Changed

  • Wraps LabelGroup, NavList, SegmentedControl, TreeView, and UnderlineNav CSS module styles in named Primer component layers.
  • Switches the CSS layer test to discover migrated runtime CSS modules by glob while excluding story, dev, feature, example, and test CSS modules.

Removed

  • None

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

  • Run cd packages/react && npx vitest run src/__tests__/css-layers.test.ts --config vitest.config.mts.
  • Review this PR as part of the CSS layers stack; this entry covers LabelGroup, NavList, SegmentedControl, TreeView, and UnderlineNav.

Merge checklist

@changeset-bot

changeset-bot Bot commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: da7fbbd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the staff Author is a staff member label Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

To publish a canary release for integration testing, apply the Canary Release label to this PR.

@github-actions github-actions Bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jun 9, 2026
@joshblack joshblack changed the title feat: add CSS Layers to 12-navigation-composites feat: add CSS Layer support to navigation composites Jun 9, 2026
@primer

primer Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

🤖 Lint issues have been automatically fixed and committed to this PR.

@joshblack joshblack force-pushed the css-layers/11-filtered-form-select-panel branch from c46e336 to 713bab3 Compare June 9, 2026 20:14
@joshblack joshblack force-pushed the css-layers/12-navigation-composites branch from e43cee8 to 1040261 Compare June 9, 2026 20:15
@github-actions github-actions Bot requested a deployment to storybook-preview-7962 June 9, 2026 20:19 Abandoned
@primer

primer Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

🤖 Lint issues have been automatically fixed and committed to this PR.

@joshblack joshblack force-pushed the css-layers/11-filtered-form-select-panel branch from 713bab3 to f4173a3 Compare June 9, 2026 20:24
@joshblack joshblack force-pushed the css-layers/12-navigation-composites branch from 1040261 to da7fbbd Compare June 9, 2026 20:27
@joshblack joshblack force-pushed the css-layers/11-filtered-form-select-panel branch from f4173a3 to 22420b1 Compare June 9, 2026 20:27
joshblack and others added 2 commits June 9, 2026 15:28
@joshblack
feat: add CSS Layers to 12-navigation-composites
7b5cc02 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@joshblack
chore: standardize CSS layer changeset wording
196ff01 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@joshblack joshblack force-pushed the css-layers/12-navigation-composites branch from da7fbbd to 196ff01 Compare June 9, 2026 20:29
@joshblack joshblack force-pushed the css-layers/11-filtered-form-select-panel branch from 22420b1 to 296d267 Compare June 9, 2026 20:29
@github-actions github-actions Bot requested a deployment to storybook-preview-7962 June 9, 2026 20:32 Abandoned
@primer

primer Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

🤖 Lint issues have been automatically fixed and committed to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@joshblack