Require explicit selection for initial container assignment - #535
Open
frankii91 wants to merge 2 commits into
Open
Require explicit selection for initial container assignment#535frankii91 wants to merge 2 commits into
frankii91 wants to merge 2 commits into
Conversation
frankii91
marked this pull request as ready for review
July 26, 2026 12:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
templatesForAssignmentwas populated automatically with every eligible unlinked serial-bearing token. This happened outside the user-selection dialog, and the existinginitSyncedfield was never set after a successful synchronization. Consequently, unrelated token details could be included during normal synchronization and initial assignment could be considered repeatedly.Behavior after this change
initSyncedremains false and synchronization can be retriedinitSyncedis persisted as trueValidation
flutter test --no-pub test/unit_test/api/privacy_idea_container_api_test.dartflutter test --no-pub test/unit_test/state_notifiers/token_container_notifier_test.dartflutter analyze --no-pubfound no errors or warnings; four pre-existingprefer_initializing_formalsinfo diagnostics remain