Remote DAP Server Fix to resolve file paths correctly.#133
Conversation
| }, | ||
| "remoteServerMode": { | ||
| "type": "boolean", | ||
| "description": "Indicates that the `probe-rs dap-server` is running on a different machine from the VSCode client. When in effect, the extension reads `programBinary`, `svdFile`, and `chipDescriptionPath` on the client side and uploads their contents (base64-encoded) to the server, so the server does not need filesystem access to those files. The server also emits source paths from DWARF debug information verbatim, with path resolution and any source-path rewriting handled by the client via `sourceFileMap`. \n\nWhen this property is omitted, the extension auto-detects remote mode from `server`: a loopback `server` (e.g. `127.0.0.1:50000`, `localhost:50000`, `[::1]:50000`) is treated as local and a non-loopback host is treated as remote. Set this property explicitly to override the heuristic for setups where the loopback detection is misleading (e.g. docker port-forward to host, WSL2 ↔ Windows host, or to force the upload path locally for testing)." |
There was a problem hiding this comment.
Does any of this actually matter for users, or is this just unnecessary LLM-essaying?
There was a problem hiding this comment.
Most VSCode users (me most of the time ) rely on inline code docs for knowing which properties are available and what they do, when you setup a launch.json. This one is a bit subtle, designed so that by default you don't have to mess with it, but for edge cases, you can override it. The alternative is to send the to the docs which seems like gratuituous UX friction.
There was a problem hiding this comment.
So you're saying that details as fine as base64-encoding file contents is valuable here?
There was a problem hiding this comment.
Honestly, they are fine by me. I don't think they detract and the VSCode UX can handle that size comment easily. If you give me a hint or lint into how much I should trim, I'd be happy to :)
Fixing/completing remote DAP server support
This fix is synchronized accross 3 PRs ,
probe-rs/probe-rs,probe-rs/vscode, andprobe-rs/webpage.