Skip to content

Restore FES warnings in createVector via this.constructor._friendlyError #8829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ksen0 merged 2 commits into from
May 27, 2026
+3 −3
Merged

Restore FES warnings in createVector via this.constructor._friendlyError #8829

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d439d28
fixing FES
perminder-17 May 26, 2026
114805b
trigger ci
ksen0 May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/math/patch-vector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { Vector } from './p5.Vector.js';
export function _defaultEmptyVector(target){
return function(...args){
if(args.length === 0){
this._friendlyError(
this.constructor._friendlyError(
'In 1.x, createVector() was a shortcut for createVector(0, 0, 0). In 2.x, p5.js has vectors of any dimension, so you must provide your desired number of zeros. Use createVector(0, 0) for a 2D vector and createVector(0, 0, 0) for a 3D vector.',
'p5.createVector'
);
Expand Down Expand Up @@ -49,7 +49,7 @@ export function _validatedVectorOperation(expectsSoloNumberArgument){
for (let i = 0; i < args.length; i++) {
const v = args[i];
if (typeof v !== 'number' || !Number.isFinite(v)) {
if (!Vector.friendlyErrorsDisabled()) {
if (!this.friendlyErrorsDisabled()) {
this._friendlyError(
'Arguments contain non-finite numbers',
'p5.Vector'
Expand All @@ -60,7 +60,7 @@ export function _validatedVectorOperation(expectsSoloNumberArgument){
}
} else {
if (typeof args !== 'number' || !Number.isFinite(args)) {
if (!Vector.friendlyErrorsDisabled()) {
if (!this.friendlyErrorsDisabled()) {
this._friendlyError(
'Arguments contain non-finite numbers',
'p5.Vector'
Expand Down
Loading