Union members upgrade fix.

print_service/routes/user.py

@@ -10,7 +10,7 @@
 
 from print_service import __version__
 from print_service.exceptions import UnionStudentDuplicate, UserNotFound
-from print_service.models import UnionMember
+from print_service.models import File, PrintFact, UnionMember
 from print_service.schema import BaseModel
 from print_service.settings import get_settings
 
@@ -90,7 +90,7 @@ def update_list(
         set(student_numbers)
     ):
         raise UnionStudentDuplicate()
-
+    users_id = []
     for user in input.users:
         db_user: UnionMember = (
             db.session.query(UnionMember)
@@ -108,21 +108,35 @@ def update_list(
             )
             .one_or_none()
         )
-
         if db_user:
             db_user.surname = user.username
             db_user.union_number = user.union_number
             db_user.student_number = user.student_number
         else:
             db.session.add(
-                UnionMember(
+                db_user := UnionMember(
                     surname=user.username,
                     union_number=user.union_number,
                     student_number=user.student_number,
                 )
             )
         db.session.flush()
-
+        users_id.append(db_user.id)
+    db_delete_print_facts: list[PrintFact] = (
+        db.session.query(PrintFact).filter(PrintFact.owner_id.notin_(users_id)).all()
+    )
+    db_delete_files: list[File] = db.session.query(File).filter(File.owner_id.notin_(users_id)).all()
+    db_delete_users: list[UnionMember] = (
+        db.session.query(UnionMember).filter(UnionMember.id.notin_(users_id)).all()
+    )
+    for print_fact in db_delete_print_facts:
+        db.session.delete(print_fact)
+    db.session.flush()
+    for file in db_delete_files:
+        db.session.delete(file)
+    db.session.flush()
+    for _user in db_delete_users:
+        db.session.delete(_user)
     db.session.commit()
     return {"status": "ok", "count": len(input.users)}
 

tests/test_routes/test_user.py

@@ -88,3 +88,27 @@ def test_post_list_duplicates(users, client):
     body = {'users': users}
     res = client.post(url, json=body)
     assert res.status_code == status.HTTP_400_BAD_REQUEST, res.json()
+
+
+def test_post_delete(client):
+    body = {
+        'users': [
+            {
+                'username': 'paul',
+                'union_number': '1966',
+                'student_number': '1967',
+            }
+        ],
+    }
+    params = {
+        'surname': 'paul',
+        'number': '1966',
+    }
+    res_post = client.post(url, json=body)
+    assert res_post.status_code == status.HTTP_200_OK
+    res_get1 = client.get(url, params=params)
+    assert res_get1.status_code == status.HTTP_202_ACCEPTED
+    res_post_delete = client.post(url, json={'users': []})
+    assert res_post_delete.status_code == status.HTTP_200_OK
+    res_get2 = client.get(url, params=params)
+    assert res_get2.status_code == status.HTTP_404_NOT_FOUND