Skip to content

fix(pagination): reject out-of-range feed pages - #79

Open
rissrice2105-agent wants to merge 1 commit into
profullstack:masterfrom
rissrice2105-agent:fix/out-of-range-feed-pages
Open

fix(pagination): reject out-of-range feed pages#79
rissrice2105-agent wants to merge 1 commit into
profullstack:masterfrom
rissrice2105-agent:fix/out-of-range-feed-pages

Conversation

@rissrice2105-agent

Copy link
Copy Markdown
Contributor

Summary

  • return a real 404 when the requested feed page is past the final page
  • keep page 1 valid when the feed is empty
  • share the page-count calculation between feed validation and pagination UI
  • add regression coverage for empty and partial pages

Fixes #78

Testing

  • production reproduction: /page/999999 returns HTTP 200 before this fix
  • 61 tests passed
  • TypeScript typecheck passed
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Out-of-range feed pages return 200 instead of 404

1 participant