Skip to content

fix: log CoinPay payment errors instead of silent failure #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Inkcha wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: log CoinPay payment errors instead of silent failure #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions apps/web/lib/coinpay.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ export async function createCoinpayPayment(args: {
}
return { ok: true, payment: data.payment };
} catch (err) {
console.error(`[coinpay] create payment failed:`, (err as Error).message);
return { ok: false, error: (err as Error).message };
}
}
Expand All @@ -57,10 +58,14 @@ export async function getCoinpayPayment(id: string): Promise<CoinpayPayment | nu
const res = await fetch(`${env.coinpay.baseUrl}/payments/${id}`, {
headers: { Authorization: `Bearer ${env.coinpay.apiKey}` },
});
if (!res.ok) return null;
if (!res.ok) {
console.error(`[coinpay] status fetch failed for ${id}: HTTP ${res.status}`);
return null;
}
const data = (await res.json()) as { payment?: CoinpayPayment } & CoinpayPayment;
return data.payment ?? (data.id ? data : null);
} catch {
} catch (err) {
console.error(`[coinpay] status fetch error for ${id}:`, (err as Error).message);
return null;
}
}
Expand Down