Repository navigation
0.4.2: on a TV the footer no longer covers the sign-in form - #35
Merged
Merged
Conversation
On a 960x540 TV screen the footer dock (webring row, badge and the network row, about 190px) was pinned over the bottom of the sheet with only 6rem reserved, so the password field and the Sign in / Create account button sat under it and clicks landed on the footer. - The footer moves into the sheet after the card and scrolls with it. - The sheet centres the card with auto margins instead of place-items, so a card taller than the screen scrolls from its top instead of losing it. - Up/Down on the sign-in and settings sheets step through every control, fields included (a remote has no Tab), and scroll it into view; Up from the first goes to the nav. - Fullscreen-on-first-key no longer fires from a text field or the account screens, where it could close a TV's on-screen keyboard mid-password. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a 960x540 TV screen the footer dock (webring row, badge and the network
row, about 190px) was pinned over the bottom of the sheet with only 6rem
reserved, so the password field and the Sign in / Create account button sat
under it and clicks landed on the footer.
card taller than the screen scrolls from its top instead of losing it.
fields included (a remote has no Tab), and scroll it into view; Up from
the first goes to the nav.
screens, where it could close a TV's on-screen keyboard mid-password.
Verified with puppeteer (Fire TV UA): at 960x540 and 1280x720 the password field and submit are hit-testable (before:
NAV.net-foot/pfs-footer__inneron top); at 640x360 D-pad Down walks sign-in and sign-up through every control, each scrolled into view, typing + Enter submits, no fullscreen while in the form (11/11).bun test117, 0 fail.🤖 Generated with Claude Code