Repository navigation
feat: shared profile fields on signup (@profullstack/profile) - #26
Merged
Merged
Conversation
The signup form (/signup) asks for first and last name (required) and company domain, job title and LinkedIn (optional), from @profullstack/profile 0.1.2. Plain sign-in is unchanged and never asks. - Validated on /api/v1/auth/link in signup mode before any link exists; carried on login_tokens.profile and saved to user_profiles when the link is spent. A failed save never blocks sign-in. - GET/PUT/PATCH /api/v1/me/profile via mountProfileRoutes; Settings gets a Contact details card. - Migration 0007: user_profiles (package DDL), login_tokens.profile, and an idempotent backfill of first/last name from users.name. - Field markup is the package's, served in the shell as a <template>. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts @profullstack/profile 0.1.2 for the signup profile: email, first_name, last_name (required), company_domain, job_title, linkedin_url (optional).
/api/v1/auth/linkwithmode: "signup"runsvalidateProfilebefore any link exists (400 with field errors); the validated fields ride onlogin_tokens.profileand are saved withsaveSignupProfilewhen the link is spent. A failed save never blocks sign-in.GET/PUT/PATCH /api/v1/me/profileviamountProfileRoutes. Settings has a Contact details card (prefilled from GET, saved with PATCH).user_profiles(package DDL, uuid key),login_tokens.profile jsonb, idempotent backfill of first/last fromusers.name(prod has one named user, a real name).renderProfileFields, served in the shell as a<template>; the company-from-work-email helper is served at/assets/profile.js. SW cache bumped to v6.test/signup-profile.test.js(refusal before a link, plain sign-in untouched, fields saved on verify, 401). Full suite 126/126 against local Postgres 16.🤖 Generated with Claude Code