prefer ranges algorithms over iterator-pair std calls (library + tests)#243
Closed
cameroncuster wants to merge 2 commits into
Closed
prefer ranges algorithms over iterator-pair std calls (library + tests)#243cameroncuster wants to merge 2 commits into
cameroncuster wants to merge 2 commits into
Conversation
Convert the full-range std::iota(begin, end, v) calls to ranges::iota(range, v). This favors the ranges algorithms already used throughout the library and removes an all(...) macro expansion on main. Partial-range calls (e.g. iterator sub-ranges) and std::partial_sum are left as-is: partial_sum has no ranges equivalent, and partial ranges read more clearly with explicit iterators.
Convert the remaining full-range std algorithm calls to their ranges:: equivalents: - virtual_tree: unique(all(subset)) -> begin(ranges::unique(subset)) - edge_cd: partition(all(g[u]), ...) -> begin(ranges::partition(g[u], ...)) ranges::unique / ranges::partition return a subrange, so begin(...) yields the iterator the erase / offset logic needs. Partial-range calls (iterator sub-ranges) and std::partial_sum are still left as-is: partial_sum has no ranges equivalent, and partial ranges read more clearly with explicit iterators.
Member
Author
|
Superseded by #244 (branch renamed use-ranges-iota -> use-ranges-algorithms as scope expanded to ranges::unique/partition/remove_if/next_permutation across library + tests). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Prefer the
ranges::algorithms over their iterator-pairstd::counterparts for full-range calls, across both the library and the
test suite. The rule: use
ranges::even whenall()would work, unlessiterators specifically make more sense.
Conversions applied:
iota(all(x), v)→ranges::iota(x, v)unique(all(x))→begin(ranges::unique(x))(erase /== endidioms)partition(all(x), pred)→begin(ranges::partition(x, pred))remove_if(all(x), pred)→begin(ranges::remove_if(x, pred))(erase)next_permutation(all(x))→ranges::next_permutation(x).foundranges::unique/ranges::partition/ranges::remove_ifreturn asubrange, so
begin(...)yields the iterator the erase / offset logicneeds;
ranges::next_permutationreturns a struct whose.founddrivesthe
do/while.Why
ranges::algorithms extensively(e.g.
ranges::sorteverywhere); this makes the remaining full-rangecalls consistent with that style.
all(...)macro expansion (relevant when expanding KACTLmacros on
main).Scope / what is intentionally NOT changed
std::partial_sumandstd::accumulate— noranges::numeric-reduction equivalents in C++23 (
ranges::fold_leftwould changethe idiom), so these stay as-is.
lower_bound(begin(sa) + lo, ...),find_if(rank + begin(mat), ...),partition(el, er, ...),remove_if(idx + begin(upd_st), ...)) — readmore clearly with explicit iterators.
find/count— notstd::algorithms.std::min/std::max.Files
library/ (12 sites, 12 files): line_tree, mst,
offline_incremental_scc, complement_graph_ccs, calc_sieve,
calc_linear_sieve, lcs_dp, longest_palindrome_query, suffix_array (2),
suffix_array_short (iota); virtual_tree (unique); edge_cd (partition).
tests/ (10 files): bit_ordered_set, kth_smallest_pst, mode_query,
sa_sort_pairs, seg_tree_find (unique); mono_st_asserts,
offline_incremental_scc, sa_sort_pairs (iota); permutation_tree_small,
rmq_small_n (iota + next_permutation); single_matching_bs (remove_if).
Testing
Syntax-checked all affected library-checker/aizu tests locally with
clang++ -std=c++2b -fsyntax-only— all pass.Behaviorally ran (exit 0, all asserts pass):
edge_cd_small_trees— exhaustive over all trees on 2–7 nodes(
ranges::partition).lca_all_methods_aizu— includescompress_tree_asserts, comparingcompress_treeagainst KACTL's reference over random subsets plus theempty-subset edge case (
ranges::unique).permutation_tree_smallandrmq_small_n— exhaustive over allpermutations of size 1–8 (
ranges::next_permutation(...).found,ranges::iota).