Skip to content

[Feature] Updating with configurable timeout feature and documentation - #1085

Merged
antonio-amjr merged 3 commits into
project-chip:v2.16-beta2+summer2026from
antonio-amjr:feature/configurable_timeouts
Aug 26, 2026
Merged

antonio-amjr merged 3 commits into
project-chip:v2.16-beta2+summer2026from
antonio-amjr:feature/configurable_timeouts

Conversation

@antonio-amjr

Copy link
Copy Markdown
Contributor

Fix: #1038
Depends on:

  1. [Feature] Adding THconfig schema as a new TH config field certification-tool-backend#356
  2. [Feature] Removing hardcoded prompt timeout matter-test-scripts#801
  3. [Feature] Adding a CLI timeout flag and unit tests certification-tool-cli#109

Description

Updates backend and cli submodules with the configurable timeout feature, and updates the Matter TH User Guide.

Changed

  • Update backend → includes th_config/prompt-timeout feature.
  • Update cli → includes --prompt-timeout flag.
  • docs/Matter_TH_User_Guide/Matter_TH_User_Guide.adoc: documents th_config (new JSON example, new "User Prompt Timeout Configuration" section), updates "Python Test Logging Configuration" to describe the config/env-var fallback, documents
    --prompt-timeout, disambiguates from the unrelated test_parameters.timeout, changelog entry.

Test plan

  • Docs-only + submodule bumps here; functional testing covered by the backend/CLI PRs.
  • Merge only after backend and CLI PRs land.

@antonio-amjr antonio-amjr self-assigned this Aug 21, 2026
@antonio-amjr antonio-amjr added Feature Backend CLI Matter Test Harness CLI Application related labels Aug 21, 2026
@coderabbitai

coderabbitai Bot commented Aug 21, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bffa248f-bea4-4efe-af4f-2e038f6b2ed5

📥 Commits

Reviewing files that changed from the base of the PR and between 26a4b6d and 4b89e29.

⛔ Files ignored due to path filters (1)
  • docs/Matter_TH_User_Guide/Matter_TH_User_Guide.pdf is excluded by !**/*.pdf
📒 Files selected for processing (4)
  • backend
  • cli
  • docker-compose.yml
  • docs/Matter_TH_User_Guide/Matter_TH_User_Guide.adoc

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The backend and CLI submodule references were updated. The backend container image now uses the matching backend revision. The user guide adds the th_config object with prompt timeout and Python test logging settings. It documents precedence between project configuration and the environment variable. It also documents the execution-only --prompt-timeout option and clarifies the difference between prompt and test execution timeouts.

Suggested reviewers: oxesoft, rquidute

Merge Risk: 🔵 Low · up to 4b89e

The user guide contains a malformed JSON configuration example that could cause copied configurations to fail parsing. This is a bounded documentation issue; the PR is otherwise mergeable with explicit owner follow-up to add the missing comma.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the configurable timeout feature and related documentation updates.
Description check ✅ Passed The description directly explains the backend and CLI updates, documentation changes, dependencies, and test scope.
Linked Issues check ✅ Passed The backend and CLI submodule updates, Docker image update, and User Guide documentation address issue #1038 by introducing configurable user-prompt timeouts and the --prompt-timeout option.
Out of Scope Changes check ✅ Passed All reviewed changes support the configurable user-prompt timeout feature or document its configuration. No unrelated changes are evident.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.)


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mergify

mergify Bot commented Aug 21, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@antonio-amjr
antonio-amjr merged commit 9ef9a4e into project-chip:v2.16-beta2+summer2026 Aug 26, 2026
5 checks passed
@antonio-amjr
antonio-amjr deleted the feature/configurable_timeouts branch August 26, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backend CLI Matter Test Harness CLI Application related Feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configurable timeout for user prompts (currently hardcoded to 60 seconds)

2 participants