pkg zap-cli with node20-linuxstatic + CI portability checks - #1707
Open
brdandu wants to merge 3 commits into
Open
pkg zap-cli with node20-linuxstatic + CI portability checks#1707brdandu wants to merge 3 commits into
brdandu wants to merge 3 commits into
Conversation
brdandu
commented
May 11, 2026
Collaborator
- Switch pkg:linux targets from node20-linux-{x64,arm64} to node20-linuxstatic-{x64,arm64} to avoid host GLIBC version coupling.
- In matter.yml and release.yml: after the Linux build, assert zap-cli is fully static (file/objdump) and has no GLIBC versioned symbols.
- Add linux-portability-test job (ubuntu:22.04, debian:bullseye, rockylinux:8) to run zap-cli --version on old glibc and selfCheck dquote> - JIRA: ZAPP-1717
- Switch pkg:linux targets from node20-linux-{x64,arm64} to
node20-linuxstatic-{x64,arm64} to avoid host GLIBC version coupling.
- In matter.yml and release.yml: after the Linux build, assert zap-cli is
fully static (file/objdump) and has no GLIBC versioned symbols.
- Add linux-portability-test job (ubuntu:22.04, debian:bullseye, rockylinux:8)
to run zap-cli --version on old glibc and selfCheck
dquote> - JIRA: ZAPP-1717
brdandu
requested review from
dhchandw,
ethanzhouyc,
paulr34 and
tecimovic
as code owners
May 11, 2026 18:53
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the pkg:linux script in package.json to use linuxstatic targets for both x64 and arm64 architectures. The reviewer identified that this change will likely break the packaging workflow due to filename mismatches expected by downstream scripts and noted inconsistencies with other target configurations in the same file that were not updated.
| "pack:cli:mac": "node ./src-script/pack-cli.js -p mac", | ||
| "pkg": "npx pkg --out-path dist/ --compress GZip --options max-old-space-size=4096 .", | ||
| "pkg:linux": "npx pkg -t node20-linux-x64,node20-linux-arm64 --public --no-bytecode --output dist/zap-linux --compress GZip --options max-old-space-size=4096 .", | ||
| "pkg:linux": "npx pkg -t node20-linuxstatic-x64,node20-linuxstatic-arm64 --public --no-bytecode --output dist/zap-linux --compress GZip --options max-old-space-size=4096 .", |
Contributor
There was a problem hiding this comment.
Switching the target platform from linux to linuxstatic will likely break the packaging workflow:
- Filename Mismatch:
pkggenerates output filenames based on the target platform string. Changinglinuxtolinuxstaticwill likely result in filenames likezap-linux-linuxstatic-x64(and-arm64), which will causesrc-script/pack-cli.js(lines 67 and 70) to fail as it expectszap-linux-x64(and-arm64). - Inconsistency: Other references to
node20-linux-x64in this file, specifically thepkg-use-local-forkscript (line 120) and thepkg.targetsconfiguration (line 368), have not been updated. These should be synchronized tonode20-linuxstatic-x64to ensure consistent behavior across all packaging commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.