Skip to content

fix: umount: delete the right metapath #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hallyn wants to merge 1 commit into from
Closed

fix: umount: delete the right metapath #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions pkg/molecule/molecule.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,11 +415,7 @@ func UmountWithMetadir(dest, metadirArg string) error {
}
}

mountNSName, err := common.GetMountNSName()

@mikemccracken mikemccracken Apr 24, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how GetMountNSName() could be returning a string with duplicate path info like you mention in the summary.

GetMountNSName() just looks at the /proc/self/ns/mnt link and strips the result, it should only return a namespace ID number (as a string), like 4026531841.

@hallyn hallyn Apr 26, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I just ran with a patch which prints out the values of mountNSName, common.ReplacePathSeparators(dest)), and common.RuntimeDir(metadir).

Please do that and let us know what you get. It's possible somethign in my context was weird, but what I did was: incus shell vm1; su - ubuntu; lxc-usernsexec -s -- bash; and inside that shell I did atomfs mount.

if err != nil {
return err
}
destMetaDir := filepath.Join(common.RuntimeDir(metadir), "meta", mountNSName, common.ReplacePathSeparators(dest))
destMetaDir := filepath.Join(common.RuntimeDir(metadir))
if err := os.RemoveAll(destMetaDir); err != nil {
return err
}
Expand Down