Fix/bump docker and container storage#764
Merged
rchincha merged 11 commits intoMay 20, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #764 +/- ##
==========================================
+ Coverage 54.22% 54.83% +0.60%
==========================================
Files 55 55
Lines 5909 5909
==========================================
+ Hits 3204 3240 +36
+ Misses 2126 2096 -30
+ Partials 579 573 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
btw, |
Signed-off-by: Ryan Harper <ryaharpe@cisco.com> Signed-off-by: Ryan Harper <rharper@woxford.com>
…r the binary Signed-off-by: Ryan Harper <ryaharpe@cisco.com> Signed-off-by: Ryan Harper <rharper@woxford.com>
…ude by default Signed-off-by: Ryan Harper <ryaharpe@cisco.com> Signed-off-by: Ryan Harper <rharper@woxford.com>
…ix cves Signed-off-by: Ryan Harper <ryaharpe@cisco.com> Signed-off-by: Ryan Harper <rharper@woxford.com>
Signed-off-by: Ryan Harper <ryaharpe@cisco.com> Signed-off-by: Ryan Harper <rharper@woxford.com>
Signed-off-by: Ryan Harper <ryaharpe@cisco.com> Signed-off-by: Ryan Harper <rharper@woxford.com>
Signed-off-by: Ryan Harper <ryaharpe@cisco.com> Signed-off-by: Ryan Harper <rharper@woxford.com>
Signed-off-by: Ryan Harper <ryaharpe@cisco.com> Signed-off-by: Ryan Harper <rharper@woxford.com>
Signed-off-by: Ryan Harper <ryaharpe@cisco.com> Signed-off-by: Ryan Harper <rharper@woxford.com>
Not quite sure why git commands on github workflow for test doesn't think the current working directory is a git repo but it fails with git fatal -128 return code. Avoid this by passing in the two values that matter: VERSION_FULL (which is the git describe with optional -dirty suffix) TOP_LEVEL (which is the top of the git tree repo) In helpers.bash, drop run_git and use these values as needed Signed-off-by: Ryan Harper <rharper@woxford.com>
raharper
force-pushed
the
fix/bump-docker-and-container-storage
branch
from
May 19, 2026 16:18
10bac13 to
89122d5
Compare
Add test coverage for paths where we log and return errors. Signed-off-by: Ryan Harper <ryaharpe@cisco.com>
raharper
marked this pull request as ready for review
May 19, 2026 18:20
raharper
requested review from
hallyn,
mikemccracken,
rchamarthy,
rchincha,
smoser and
tych0
as code owners
May 19, 2026 18:20
Contributor
Author
Not clear what's going on in the VM here, but something was up with how it was using git. I've changed test to not use |
rchincha
approved these changes
May 20, 2026
raharper
added a commit
to raharper/stacker
that referenced
this pull request
Jun 24, 2026
* chore: add make lint earlier to github build workflow Signed-off-by: Ryan Harper <ryaharpe@cisco.com> Signed-off-by: Ryan Harper <rharper@woxford.com> * fix: makefile ensure lint target creates the output directory path for the binary Signed-off-by: Ryan Harper <ryaharpe@cisco.com> Signed-off-by: Ryan Harper <rharper@woxford.com> * fix: add git to common debs for debian/ubuntu images which don't include by default Signed-off-by: Ryan Harper <ryaharpe@cisco.com> Signed-off-by: Ryan Harper <rharper@woxford.com> * fix: bump container images and storage to move up docker version to fix cves Signed-off-by: Ryan Harper <ryaharpe@cisco.com> Signed-off-by: Ryan Harper <rharper@woxford.com> * chore: updated go.sum for recent go.mod updates Signed-off-by: Ryan Harper <ryaharpe@cisco.com> Signed-off-by: Ryan Harper <rharper@woxford.com> * fix: update stacker convert to work with updated buildkit Signed-off-by: Ryan Harper <ryaharpe@cisco.com> Signed-off-by: Ryan Harper <rharper@woxford.com> * fix: go.mod updated to remove unneeded replace, bump for fixing CVEs Signed-off-by: Ryan Harper <ryaharpe@cisco.com> Signed-off-by: Ryan Harper <rharper@woxford.com> * fix: update go.sum after go.mod updates Signed-off-by: Ryan Harper <ryaharpe@cisco.com> Signed-off-by: Ryan Harper <rharper@woxford.com> * fix: update go version in github workflow files Signed-off-by: Ryan Harper <ryaharpe@cisco.com> Signed-off-by: Ryan Harper <rharper@woxford.com> * fix: Remove using git inside test suite Not quite sure why git commands on github workflow for test doesn't think the current working directory is a git repo but it fails with git fatal -128 return code. Avoid this by passing in the two values that matter: VERSION_FULL (which is the git describe with optional -dirty suffix) TOP_LEVEL (which is the top of the git tree repo) In helpers.bash, drop run_git and use these values as needed Signed-off-by: Ryan Harper <rharper@woxford.com> * test: Add test coverage for stacker convert where we return errors Add test coverage for paths where we log and return errors. Signed-off-by: Ryan Harper <ryaharpe@cisco.com> --------- Signed-off-by: Ryan Harper <ryaharpe@cisco.com> Signed-off-by: Ryan Harper <rharper@woxford.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
cleanup
Which issue does this PR fix:
CVEs
#742
#734
#732
#708
#704
What does this PR do / Why do we need it:
Address upstream go CVEs
If an issue # is not available please add repro steps and logs showing the issue:
security scan on stacker binary
Testing done on this change:
make test && make lint
Automation added to e2e:
none
Will this break upgrades or downgrades?
no
Does this PR introduce any user-facing change?:
no
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.