preserve original query encoding in OrderedParams round-trip (#379)#747
Open
Mzack9999 wants to merge 1 commit into
Open
preserve original query encoding in OrderedParams round-trip (#379)#747Mzack9999 wants to merge 1 commit into
Mzack9999 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #379.
urlutil.OrderedParamsnow stores each parameter as a standalone entry that remembers the original encoded segment.Decodefollowed byEncode(with no mutations) produces a byte-for-byte identical query string, so parameters that came in without=stay without=, original escape choices (+vs%20,%3Dvs=) are preserved, and flippingIncludeEqualsno longer mangles decoded entries - the flag only governs programmatically added/mutated parameters.Entries touched via
Add/Set/Updatego throughParamEncode+IncludeEqualsexactly as before; untouched siblings stay verbatim.SetandUpdatenow replace in place at the first occurrence of the key (preserving insertion order) instead of moving the key to the end.Validated against
nuclei(pkg/fuzz/...,pkg/protocols/...,pkg/authprovider/...) and the fullhttpxtest suite with a local replace - both build and pass.