chore: Add check-license CI job#770
Merged
Merged
Conversation
SuperQ
force-pushed
the
superq/check-license
branch
6 times, most recently
from
1deb5e3 to
e5104f5
Compare
Add a CI job to check js/ts files for the copyright/license header. Signed-off-by: SuperQ <superq@gmail.com>
Signed-off-by: SuperQ <superq@gmail.com>
SuperQ
force-pushed
the
superq/check-license
branch
from
e5104f5 to
9ba7a2b
Compare
Signed-off-by: Jason Marshall <jdmarshall@users.noreply.github.com>
jdmarshall
reviewed
Jul 12, 2026
jdmarshall
left a comment
jdmarshall
left a comment
Contributor
There was a problem hiding this comment.
Don’t copyright statements require a year?
At least it’s mercifully short. I was starting to get flashbacks to Java’s flow-destroying four page copyright statements at the top of each file.
Member
Author
|
No, it's recommended in the CNCF guidelines to remove the dates. See also PROM-50. Hah, yea, I wouldn't want that either. |
jdmarshall
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a CI job to check js/ts files for the copyright/license header.
Signed-off-by: SuperQ superq@gmail.com