Skip to content

fix(types): allow string[] label values #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AysajanE wants to merge 1 commit into from
+3 −1
Closed

fix(types): allow string[] label values #774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ type MetricValueWithName<T extends string> = MetricValue<T> & {

type LabelValues<T extends string> = T extends NoLabelNameType
? Partial<Record<string, never>>
: Partial<Record<T, string | number>>;
: Partial<Record<T, string | number | string[]>>;

interface MetricConfiguration<T extends string> {
name: string;
Expand Down
2 changes: 2 additions & 0 deletions test/typescript.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,10 @@ const registry = new Registry();
const counter = new Counter({
name: 'typescript_test_counter',
help: 'TypeScript test counter',
labelNames: ['handler'],
registers: [registry],
});
counter.inc({ handler: ['/a', '/b'] });

const metricsText: Promise<string> = registry.getMetricsAsString(counter);
const gatewayWithRegistry = new Pushgateway('http://127.0.0.1:9091', registry);
Expand Down