Use object instead of Any for labels() parameters#1186
Open
gregoiredx wants to merge 1 commit into
Open
Conversation
9c154a6 to
49c6c19
Compare
Author
|
Hello @csmarchbanks 👋 Following the CONTRIBUTING.md, I should ping you to get your review for a trivial change. This is just a type change from |
Signed-off-by: Grégoire Deveaux <gregoire.deveaux@gitguardian.com>
49c6c19 to
757abe8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working on a project where we try to reduce lines flagged as
Anyby mypy line precision report.The type of
labels()parameters isAny, reducing the whole line asAny(mypy takes the worst of the line typing for its report).Using
objecthere looks like the right choice.From https://mypy.readthedocs.io/en/stable/kinds_of_types.html#the-any-type
I first thought it would even be
strsince it's the natural type of labels, butlabels()transforms parameters to strings automatically (labelvalues = tuple(str(labelkwargs[l]) for l in self._labelnames)andlabelvalues = tuple(str(l) for l in labelvalues)).So we mean "anything that can be
stred",objectlooks like a good candidate for that type.Note: I had to introduce
str_labelvaluesto comply withmypy(since nowlabelvalueshas typetuple[object, ...]which is not compatible withtuple[str, ...]).