feat(react): theme the autocomplete menu via CSS variables#39
Draft
ocavue wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
ocavue
force-pushed
the
ocavue/autocomplete-menu-polish
branch
from
38f7e6e to
81dd54c
Compare
ocavue
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The built-in tag / wikilink menu had hardcoded colors, radii, and shadow. Expose them as CSS variables so a host can restyle the menu to match its design system without markup hooks.
autocomplete-menu.module.cssnow reads (each falling back to the current default):--meowdown-menu-background,--meowdown-menu-border,--meowdown-menu-radius,--meowdown-menu-shadow,--meowdown-menu-item-radius,--meowdown-menu-item-highlight. The variable list is documented at the top of that file.(The menu is already flicker-free:
fetchItemsnever clears the currentitemsbefore a new query resolves, so previous results stay visible during an in-flight search. No code change needed for that.)