feat(core): render wikilinks as an immutable mark view#73
Draft
ocavue wants to merge 20 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
…links # Conflicts: # packages/core/src/extensions/wikilink-click.ts
…links # Conflicts: # packages/core/src/extensions/image-navigation.ts # packages/core/src/extensions/wikilink-click.ts
…links # Conflicts: # website/src/app.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Render
[[target]]/[[target|alias]]in place via a mark view as an immutable label, mirroring the inline image: the raw source is hidden in hide/focus mode and the rendered label stands in for it. In hide mode the link is a single caret stop, arrowing onto it selects the whole source and Backspace/Delete remove it as a unit. The shared caret-stop logic is extracted intodefineAtomicMarkNavigationand reused by both images and wikilinks.