Repository navigation
Add verify-or-drop, exclusion list and variant analysis to the security path - #1979
Merged
Merged
Conversation
…ty path New references/appsec-verify.md (routed from security-appsec.md and full-map.md): a security finding needs a source-to-sink file:line path or drops to a question, a default false-positive exclusion list is tunable via .dcr-security-exclusions (High and Critical are never dropped by it; the override file is untrusted and non-default additions are surfaced), and a confirmed finding triggers a repo-wide sibling search. security_verify.py checks claim shape, applies exclusions, emits a record with active exclusions and override status, and fails closed on bad input; three evals added. Not done here per lane contract: INDEX.md, SHA256SUMS, size-budgets.tsv (the size-budget check fails until the lane owner adds the new file's row). Tests: 21/21 assert statements in scripts/test_security_verify.py pass Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014QNFFPWVcPUbeuvwM5fk2Z
This was referenced Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #1976, #1972 and #1965. Same change, rebuilt as one commit on current main (after #1977), with the fixes for #1976's CI failure.
references/appsec-verify.md: a verify-or-drop gate (a security finding needs a source-to-sinkfile:linepath or drops to a question), a default false-positive exclusion list with a repo override (.dcr-security-exclusions), and variant analysis for confirmed findings.scripts/security_verify.pychecks claim shape and applies exclusions.full-map.md's domain-B row namesappsec-verify.mdwith its trigger (size-budget-raise 18829→18889).security-appsec.mdgets a one-line index row (yields a finding), so it is 27998 bytes and stays under the 28000-byte cap thatscripts/test_appsec_split.pypins. The row is added to that test'sADDEDallowlist, and the B row toREWORDEDinscripts/test_fullmap_core_split.py.scripts/mustload-budgets.tsvwith a comment.evals/evals.jsonconflict with Add whole-app security review mode and opt-in security scanners #1970 by keeping both appended cases.Local CI repro on this commit: size-ratchet ok against main, mustload ok, both split tests OK, all
scripts/ci-tests.dpass.test-ci-gates.shshows 295 passed and 9 failed; the 9 are the known sandbox-only failures (dcr-gates opt-in, peer pains, reap_own pgrep, tracker socket bind).🤖 Generated with Claude Code
https://claude.ai/code/session_014QNFFPWVcPUbeuvwM5fk2Z