Added new motion blur module#1622
Draft
niravasher wants to merge 2 commits into
Draft
Conversation
Author
|
|
harshkhandeparkar
requested changes
Jul 7, 2020
Member
harshkhandeparkar
left a comment
harshkhandeparkar
left a comment
There was a problem hiding this comment.
Few small changes required.
You'll also have to add an entry for this in the module docs.
|
|
||
| function draw(input, callback, progressObj) { | ||
|
|
||
| const defaults = require('./../../util/getDefaults.js')(require('./info.json')); |
Member
There was a problem hiding this comment.
Can the require statement be pushed to the top?
| sin = Math.sin(radians); | ||
| // Final dimensions after rotation | ||
|
|
||
| const finalPixels = require('ndarray')( |
| ] | ||
| ); | ||
|
|
||
| pixels = require('./MotionBlur')(pixels, finalPixels, rotate_value, width, height, cos, sin); |
| ndarray = require('ndarray'); | ||
|
|
||
| module.exports = exports = function(pixels, finalPixels, rotate_value, width, height, cos, sin) { | ||
| const pixelSetter = require('../../util/pixelSetter.js'); |
| "step": "1" | ||
| } | ||
| }, | ||
| "docs-link":"https://github.com/publiclab/image-sequencer/blob/main/docs/MODULES.md#blur-module" |
Member
There was a problem hiding this comment.
Needs the correct link.
harshkhandeparkar
added
the
almost-complete
|
|
harshkhandeparkar
removed
the
almost-complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1618 (<=== Replace
0000with the Issue Number)Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm run test-all@publiclab/is-reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!