Fix resources created in apply in aws-py-hub-and-spoke-network#2678
Merged
Fix resources created in apply in aws-py-hub-and-spoke-network#2678
Conversation
Refactor spoke and inspection VPCs to avoid creating resources inside apply() callbacks, which causes preview to not show those resources. Use VPC component outputs directly instead of get_subnets_output data source lookups, and use _output variants of data source functions. Also updates dependencies to latest major versions, fixes subnet strategy warnings, removes unused imports, and fixes a README typo. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Frassle
approved these changes
Apr 16, 2026
CamSoper
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apply()callbacks, which caused those resources to not appear inpulumi previewget_subnets_outputdata source lookups with direct VPC component outputs (isolated_subnet_ids,public_subnet_ids) so resources appear in preview even on fresh stacks_outputvariants of data source functions (get_route_table_output,get_subnet_output) to work withOutput[str]valuesrequirements.txtto latest major versions, fix AWSX subnet strategy warnings, remove unused importsTest plan
pulumi previewsucceeds with 138 resources, no errors or warningsmake check_python_formatting)🤖 Generated with Claude Code