Skip to content

Relax dependnecy on JWT#20

Open
byroot wants to merge 1 commit into
pushpad:masterfrom
byroot:relax-jwt
Open

Relax dependnecy on JWT#20
byroot wants to merge 1 commit into
pushpad:masterfrom
byroot:relax-jwt

Conversation

@byroot

@byroot byroot commented Apr 9, 2026

Copy link
Copy Markdown

jwt is a very popular depdency, and numerous other gems are yet to be updated to allow jwt 3.x.

Since web-push works fine with jwt 2.x, I see no reason to prevent installation.

`jwt` is a very popular depdency, and numerous other gems are yet
to be updated to allow `jwt 3.x`.

Since `web-push` works fine with `jwt 2.x`, I see no reason to prevent
installation.
@byroot

byroot commented Jun 11, 2026

Copy link
Copy Markdown
Author

👋 @collimarco sorry for the ping, but could you consider this PR?

@collimarco

Copy link
Copy Markdown
Contributor

@byroot Thanks for your contribution. Personally I don't see much value in this change: jwt v3 was released 1 year ago and this gem reflects that... Otherwise I would need to create a new release for this change (which isn't relevant for other users) and then another future release again to drop support for it. As a temporary workaround, until you update jwt in your application, which is the recommended approach, you can use v3.0.1, which uses jwt v2. The newer versions of this gem are just version upgrades of gem dependencies, so if you don't want them, just keep using the older version for some time.

@byroot

byroot commented Jun 11, 2026

Copy link
Copy Markdown
Author

Personally I don't see much value in this change

The value is that I'm currently fighting with two other gems that have a dependency on jwt ~> 2.x, but initially what I wanted to do was to upgrade to openssl 4.x, which I can't because web-push, so I want #19

The value of this change is to get your users out of dependency hell, by allowing more progressive upgrades.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants