Open
Conversation
cwhanse
reviewed
Mar 30, 2026
docs/sphinx/source/contributing/introduction_to_contributing.rst
Outdated
Show resolved
Hide resolved
docs/sphinx/source/contributing/introduction_to_contributing.rst
Outdated
Show resolved
Hide resolved
docs/sphinx/source/contributing/introduction_to_contributing.rst
Outdated
Show resolved
Hide resolved
docs/sphinx/source/contributing/introduction_to_contributing.rst
Outdated
Show resolved
Hide resolved
docs/sphinx/source/contributing/introduction_to_contributing.rst
Outdated
Show resolved
Hide resolved
RDaxini
changed the title
Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
kandersolar
approved these changes
Apr 1, 2026
Member
kandersolar
left a comment
kandersolar
left a comment
There was a problem hiding this comment.
Fine with me. One lazy question below
Comment on lines
+22
to
+23
| * Every pull request (PR) should address one or more open issues. The PR should | ||
| be outlined in the issue discussion. |
Member
There was a problem hiding this comment.
Will we hold ourselves (the maintainers) to this standard? Many of my PRs do not close any issue, and I would prefer to retain that freedom. Requiring an issue for what a maintainer believes is a straightforward, non-controversial PR would (IMHO) often be repository clutter and notification noise for little benefit.
Member
There was a problem hiding this comment.
What about "Pull requests should address one or more open issues." Does that create flexibility for maintainers?
Contributor
There was a problem hiding this comment.
You could add "... unless it has been discussed with a maintainer..." somewhere in there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests addedUpdates entries indocs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.