Skip to content

Fix iotools tests for pandas 3#2730

Open
kandersolar wants to merge 7 commits intopvlib:mainfrom
kandersolar:pandas3-fixes
Open

Fix iotools tests for pandas 3#2730
kandersolar wants to merge 7 commits intopvlib:mainfrom
kandersolar:pandas3-fixes

Conversation

@kandersolar
Copy link
Copy Markdown
Member

@kandersolar kandersolar commented Apr 1, 2026

  • Closes iotools test failures with pandas 3 #2728
  • I am familiar with the contributing guidelines
  • I attest that all AI-generated material has been vetted for accuracy and is in compliance with the pvlib license
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Pretty straightforward. The only complexity is bridging the gap between pandas 2 strings (dtype('O')) and pandas 3 strings (<StringDtype(storage='python', na_value=nan)>). We could explicitly check the installed pandas version and select the appropriate dtype, but I opted to just let pandas infer the right one from the test values.

@kandersolar kandersolar added this to the v0.15.1 milestone Apr 1, 2026
@kandersolar kandersolar changed the title Fix iotools tests for pandas 3 Fix iotools tests for pandas 3 Apr 1, 2026
@kandersolar kandersolar marked this pull request as ready for review April 1, 2026 18:41
@kandersolar
Copy link
Copy Markdown
Member Author

kandersolar commented Apr 1, 2026

Ready for review. The only iotools failure was a rate limiting issue.

I disagree with the linter flag and am ignoring it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iotools test failures with pandas 3

1 participant