Bug: Revert core back to FIRMWARE_VER_CODE = 10#66
Open
zindello wants to merge 1 commit into
Open
Conversation
…nd it's preventing companions from configuring the experimental settings page (2 byte paths)
Contributor
|
Try this change first: https://github.com/agessaman/pyMC_Repeater/tree/fix/binary-persist-1150 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change with the additions highlighted with figuring out the MeshMapper bugs introduced a bug. To be fair both Claude and @agessaman did warn about this being a possibility.
On Version 11 the app assumes there is default region support, we don't have default region support so it's breaking the Experimental Settings page - which means users can't set 2 byte paths on companions from the app.
This PR reverts that. Experimental Settings works again, 2 byte paths can be set and MeshMapper remains unaffected.