Fix system gesture triggering when editing quad corners.#194
Merged
pynicolas merged 1 commit intoJun 7, 2026
Merged
Conversation
On devices without a back button (e.g. Pixel10), dragging corners when close to the screen borders triggered the system back gesture. Adding exclusion areas for each of the corner handles fixes this. It was not possible to exclude the whole image area, as Android seems to silently limit the area of allowed exclusion. The mandatory system gestures like the home or quick-switch gesture cannot be excluded via areas. The only solution here is to introduce a bottom padding which moves the image view upwards, out of the gesture area. Both changes are no-ops for devices without system gestures, so no change there. Closes pynicolas#193
Owner
|
Thanks a lot for this new PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On devices without a back button (e.g. Pixel10), dragging corners when close to the screen borders triggered the system back gesture.
QuadOverlay.kt
Adding exclusion areas for each of the corner handles fixes this. It was not possible to exclude the whole image area, as Android seems to silently limit the area of allowed exclusion.
CropScreen.kt
The mandatory system gestures like the home or quick-switch gesture cannot be excluded via areas. The only solution here is to introduce a bottom padding which moves the image view upwards, out of the gesture area.
Both changes are no-ops for devices without system gestures, so no change there.
Closes #193