mypy: fix all assignment#368
Open
Avasam wants to merge 2 commits into
Open
Conversation
Avasam
force-pushed
the
mypy--fix-all-assignment
branch
2 times, most recently
from
246817b to
e14b212
Compare
Avasam
force-pushed
the
mypy--fix-all-assignment
branch
from
e14b212 to
ca326ca
Compare
Avasam
commented
Oct 17, 2025
| if value and self.repeat.get(attr) is not None: | ||
| value = getattr(object, attr, 0) + 1 | ||
| setattr(object, attr, value) | ||
| self.option_order.append((opt, value)) |
Contributor
Author
There was a problem hiding this comment.
See discussion in https://github.com/pypa/distutils/pull/343/files#r2440199822
Avasam
commented
Oct 17, 2025
Avasam
force-pushed
the
mypy--fix-all-assignment
branch
from
ca326ca to
d4fdab6
Compare
Avasam
commented
Nov 2, 2025
|
|
||
| # Medium-easy stuff: same syntax/semantics, different names. | ||
| ext.runtime_library_dirs = build_info.get('rpath') | ||
| ext.runtime_library_dirs = build_info.get('rpath') or [] |
Contributor
Author
There was a problem hiding this comment.
Runtime change: avoid assigning None to runtime_library_dirs (I didn't fully investigate whether that should even be possible at runtime or just an artefact of code that is too dynamic to be type-safe)
Avasam
force-pushed
the
mypy--fix-all-assignment
branch
2 times, most recently
from
d577d0b to
08013fc
Compare
Avasam
force-pushed
the
mypy--fix-all-assignment
branch
from
08013fc to
acf8ee4
Compare
Avasam
force-pushed
the
mypy--fix-all-assignment
branch
2 times, most recently
from
86f20fd to
f3d74f2
Compare
Avasam
force-pushed
the
mypy--fix-all-assignment
branch
from
f3d74f2 to
54592ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.