mypy: fix all return-value+type-var#412
Open
Avasam wants to merge 1 commit into
Open
Conversation
Avasam
commented
Jul 10, 2026
Comment on lines
+1119
to
+1120
| if output_dir is None: | ||
| output_dir = "" |
Contributor
Author
There was a problem hiding this comment.
Feels odd allowing this to be None for type checking purposes, only to immediatly assert it can't be None.
If assert output_dir is not None is an invariant that must be kept, then msvc.Compiler.create_static_lib should check the return of _fix_object_args before passing it to library_filename
Avasam
force-pushed
the
mypy--fix-all-return-value+type-var
branch
from
50d02d4 to
dacecb0
Compare
Avasam
force-pushed
the
mypy--fix-all-return-value+type-var
branch
from
dacecb0 to
50aa30e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.