Harden opt-in upload privacy and reliability#1343
Conversation
Coverage Report for CI Build 26718310063Coverage increased (+0.2%) to 90.896%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
|
Hi Professor @david-yz-liu, this PR is ready for review. I don't seem to have the option to request reviewers on this PR, and this has happened on my previous PR as well. Would it be possible to give me permission to request reviews on future PRs, or let me know the preferred process? Thank you! |
|
Hi @KushGandhi3, thanks for the ping. You don't have permission to request a review, but you can continue to leave a comment and I'll request a review on your behalf. |
david-yz-liu
left a comment
There was a problem hiding this comment.
Thanks very much, @KushGandhi3! I left a few comments, but overall I think this is a great contribution to the codebase.
|
Thanks for the review @david-yz-liu! I've addressed the comments and pushed the follow-up changes. |
Proposed Changes
This pull request hardens PythonTA's opt-in upload path for privacy, reliability, and test coverage.
Previously, the anonymous upload ID was derived from
uuid.uuid1(), which can include MAC-address-derived information before hashing. This change replaces that behavior with a random local UUID, stores it on the user's machine, and sends only a SHA-512 hash of that local ID to the upload server. The uploaded ID format remains a 128-character hexadecimal hash, andget_hashed_id()is preserved as a backwards-compatible alias.This PR also improves upload reliability by:
ExitStackerrors_to_dictDocumentation and the changelog were updated to describe the new anonymous ID behavior, including the fact that existing opt-in users will receive a new anonymous ID after upgrading.
Screenshots of your changes (if applicable)
Not applicable; this PR does not change the UI.
Type of Change
Checklist
Before opening your pull request:
After opening your pull request:
Questions and Comments