Skip to content

Update configuration to support .toml files#1352

Open
a1-su wants to merge 2 commits into
pyta-uoft:masterfrom
a1-su:support-toml-configuration
Open

Update configuration to support .toml files#1352
a1-su wants to merge 2 commits into
pyta-uoft:masterfrom
a1-su:support-toml-configuration

Conversation

@a1-su
Copy link
Copy Markdown
Contributor

@a1-su a1-su commented Jun 2, 2026

Proposed Changes

This PR updates the configuration options to support .toml files, in addition to the .pylintrc that is currently used. In addition, it updates the tests to add .toml checking.

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality) X
🐛 Bug fix (non-breaking change that fixes an issue)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📚 Documentation update (change that only updates documentation)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • I have updated the project Changelog (this is required for all changes).
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Jun 2, 2026

Coverage Report for CI Build 26826362401

Coverage increased (+0.03%) to 90.726%

Details

  • Coverage increased (+0.03%) from the base build.
  • Patch coverage: 1 uncovered change across 1 file (24 of 25 lines covered, 96.0%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
packages/python-ta/src/python_ta/config/init.py 25 24 96.0%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 3968
Covered Lines: 3600
Line Coverage: 90.73%
Coverage Strength: 17.62 hits per line

💛 - Coveralls

@a1-su a1-su requested a review from david-yz-liu June 2, 2026 14:35
Copy link
Copy Markdown
Contributor

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @a1-su, nice work. The changes overall look good. A few general comments:

  1. We should update the PythonTA documentation with this new behaviour (accepting toml files, the [tool.python-ta] section, looking for pyproject.toml file by default, anything else).
  2. There are a few other places in the code base (e.g., variable names) that refer to pylintrc explicitly. These should be modified to use more general terms for "config files" or something similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants