Issue 1344 - fix three leading underscores issue in _check_method_and_attr_name#1353
Open
rachelzUT wants to merge 4 commits into
Open
Issue 1344 - fix three leading underscores issue in _check_method_and_attr_name#1353rachelzUT wants to merge 4 commits into
rachelzUT wants to merge 4 commits into
Conversation
Collaborator
Coverage Report for CI Build 26858357806Coverage increased (+0.004%) to 90.699%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Closes #1344
Modifies
InvalidNameCheckerto allow all name patterns to have up to 2 leading underscores, so_check_method_and_attr_nameno longer separately checks for double leading underscores. Suggested name fixes are also changed to suggest two leading underscores if prefixes are longer than 2 characters.Also modified
_to_snake_caseto use_parse_nameto be consistent with_to_pascal_caseand_to_upper_case_with_underscores....
Screenshots of your changes (if applicable)
Type of Change
Checklist
Before opening your pull request:
After opening your pull request:
Questions and Comments
Additionally made a few modifications to some function docstrings to reflect these (and other recent) changes.