Fix loop factory teardown ordering#1502
Conversation
Record each managed fixture's scoped runner as a pytest fixture dependency. This lets pytest invalidate async fixtures in dependency order when the loop factory parameter changes, preserving shared parents until their children have finished. Add a regression test covering an async test followed by a synchronous test that consumes a child session-scoped async fixture. Fixes pytest-dev#1501
tjkuson
left a comment
tjkuson
left a comment
There was a problem hiding this comment.
This doesn't resolve the root issue, which is that sync tests still request the loop factory unparametrized, so the cache key flips and session-scoped fixtures are torn down and rebuilt at every sync/async boundary. The rebuilt fixtures run on the default event loop rather than the configured factory, and sync tests end up with a different fixture instance than async tests in the same session.
Also, CI is failing.
|
You're right, thanks for spelling out the actual root cause — I was treating the teardown ordering as the problem when it's really a symptom. The unparametrized loop-factory request from sync tests flipping the cache key is the real issue; my patch just reshuffled when the (already wrong) rebuild happens rather than stopping it. Let me rework this so sync tests request the loop factory the same way async tests do, so the cache key stays stable across the sync/async boundary and session-scoped fixtures aren't torn down and rebuilt on the default loop. I'll fix the CI failures in the same pass. Will push an updated version rather than leave this half-addressed. |
2 participants
Fixes #1501. Loop-factory parametrization changed the scoped runner without recording it as a fixture dependency, so pytest finalized a shared parent fixture before a later synchronous test initialized its child. Recording that dependency preserves pytest's normal child-before-parent teardown order; the new regression test fails with the reported assertion before the fix and passes after it.